On May 29, 2013, at 4:57 PM, Martin Buchholz wrote: > I would like to see the real world-class experts on this scary math stuff > (Alan Eliasen, Tim Buktu) be made honorary jdk reviewers, just for their area > of specialization, if that was bureaucratically possible.
I'll leave serious comments on this topic to those vested with godlike powers. It would be nice however to have domain experts here, that's for sure. > Shouldn't the original authors be cc'ed? I think (hope) all are on core-libs-dev. > The code is awesome. My thorough review found only these defects: > > Use third person in the first sentence of a javadoc - e.g. > s/Retrieve/Retrieves/. > > --- > > Don't use the denigrated C style > char zero[] = > Instead use > char[] zero = > > --- Are the two preceding comments generic, i.e., occurring in multiple places, or each unique? > This looks odd: > normalized as a//binary* > > The original comment looked more normal: > > normalized as a *binary* > --- > > Otherwise, approved! Thanks much! Brian > > > On Fri, May 24, 2013 at 10:09 AM, Brian Burkhalter > <[email protected]> wrote: > Originally posted one month ago today. > > http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-April/016355.html > > https://www.youtube.com/watch?v=D9kv_V5lhiE > > Thanks, > > Brian >
