This seems fine to me.
David
On 5/06/2013 1:19 AM, Aleksej Efimov wrote:
Alan, Jason,
Thanks for clarification. I have moved the serial data from binary files
to test class:
http://cr.openjdk.java.net/~dmeetry/8009581/webrev.5/
<http://cr.openjdk.java.net/%7Edmeetry/8009581/webrev.5/>
-Aleksej
On 06/04/2013 05:57 PM, Alan Bateman wrote:
On 04/06/2013 14:44, Jason Mehrens wrote:
Aleksej,
Looks good to me. I think Alan wanted you to use the ser files to
create a byte array + ByteArrayInputStream in the actual test class
instead of including actual serial data files along side the test.
That would be my preference because we try to avoid binary files in
the repository.
-Alan.
