Looks good. Only a few minor nits. A few places (BiOperator) where it says "Constructs" rather than "Returns". If it is important that it constructs a new instance for consistency you may wish to say "Returns a new ..."
There are a few places of incorrect capitalization in @return and @param tags Mike On Jun 19 2013, at 11:29 , Henry Jen wrote: > A ping to wake up the thread, there is a minor update regard the use of > @apiNote since last email. > > Thanks in advance for reviewing. > > Cheers, > Henry > > > On 06/15/2013 04:28 PM, Henry Jen wrote: >> Reflecting feedbacks received so far, please see >> >> http://cr.openjdk.java.net/~henryjen/ccc/8009736.3/webrev/ >> http://cr.openjdk.java.net/~henryjen/ccc/8009736.3/specdiff >> >> Cheers, >> Henry >> >> >> On 06/11/2013 02:04 PM, Henry Jen wrote: >>> Hi, >>> >>> Please review http://cr.openjdk.java.net/~henryjen/ccc/8009736.2/webrev/ >>> >>> Highlight of changes, >>> >>> - Comparators class is now only package-private implementations. The >>> public static methods have been move to other arguably more appropriate >>> places, mostly in Comparator. >>> >>> - Comparator.reverseOrder() is renamed to Comparator.reversed() >>> >>> - nullsFirst(Comparator) and nullsLast(Comparator) are introduced to >>> wrap up a comparator to be null-friendly. >>> >>> To see the API changes, found the specdiff at >>> http://cr.openjdk.java.net/~henryjen/ccc/8009736.2/specdiff/overview-summary.html >>> >>> Cheers, >>> Henry >>> >> >
