On 07/08/2013 10:23 PM, Mandy Chung wrote:

On 7/8/2013 7:10 PM, Joe Darcy wrote:
Hello,

Please review my changes to resolve (almost all of):

    JDK-8020095 Fix doclint warnings in java.util.regex
    http://cr.openjdk.java.net/~darcy/8020095.0/


I think line 32 in Matcher.java should be {@linkplain ...} instead of {@link ...}

Agreed; I'll change that before I push.

(FWIW, I've also run specdiff over the changes and everything looks fine on that front.)


 /**
* An engine that performs match operations on a {@link java.lang.CharSequence
- * </code>character sequence<code>} by interpreting a {@link Pattern}.
+ * character sequence} by interpreting a {@link Pattern}.
  *
* <p> A matcher is created from a pattern by invoking the pattern's {@link * Pattern#matcher matcher} method. Once created, a matcher can be used to
@@ -330,7 +330,7 @@
     }

Other than that, the patch looks fine to me.


Thanks for the review Mandy,

-Joe

Reply via email to