Hi David,
thanks for reviewing this!
On 10/07/2013 6:25 AM, Kumar Srinivasan wrote:
Hi,
We had earlier added a fail over to the java implementation, for
reference:
http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/1432a6247ac9
The first time the unpacker is called an UnsatisfiedLinkError will be
thrown, but
subsequent invocations in the same JDK/VM instance, a
NoClassDefFoundError
will be thrown. This error also needs to be caught and handled.
Ugghhh. Presumably we need a test update to catch this?
Yes it is tedious to create this test, the test needs to make a copy of
the JDK under
test and modify it to remove the libunpack.so and call unpack repeatedly.
But since we already have a JCK test, I marked the bug "noreg-jck"
since the jck
test catches this scenario.
Here is the modified webrev:
http://cr.openjdk.java.net/~ksrini/8019799/webrev.0/
Looks okay - but no test.
It would be better/more-efficient if the presence of the native
implementation could be detected once during class initialization. But
I won't try to force that on you. :)
that is what I started with initially, later Bob and I agreed that
testing for libunpack.so
will need to be performed by SE always, where libunpack.so is sure to
exist.
Thanks
Kumar
Thanks,
David
Thanks
Kumar
