On 7/12/2013 2:44 AM, Chris Hegarty wrote:
The source changes look fine to me.
The tests should be located elsewhere, otherwise they will collide with an
Oracle internal repo. Say jdk/test/jaxp?
Ah, I accidentally placed them together with those original tests.
There's a place holder for jaxp: jdk/test/javax/xml/jaxp. A longer term
goal may be to migrate tests to the jaxp repo.
-Joe
As an aside, I plan to move the jaxws tests to a similar holding area,
jdk/test/jaxws. They can then follow the appropriate package structure.
-Chris
On 12 Jul 2013, at 09:59, huizhe wang <huizhe.w...@oracle.com> wrote:
Hi,
This is a quick fix on a regression caused by 8016648. The new property
manager added to handle the new jaxp 1.5 properties is only created for the
input and event factories. For the output factory therefore, there should have
a null-check. I've run the tests used in the nightly build with a local build,
all passed with this patch.
webrev:
http://cr.openjdk.java.net/~joehw/jdk8/8020430/webrev/
Thanks,
Joe
