Thank you, Alan. I really appreciate it.
Here's the mercurial export:
http://cr.openjdk.java.net/~igerasim/2commit/8020669-jdk8-readAllBytes.patch
Sincerely yours,
Ivan
On 29.07.2013 3:43, Alan Bateman wrote:
On 28/07/2013 15:08, Ivan Gerasimov wrote:
Hello Alan and everyone else
Thank you for review!
Here's another version of webrev:
http://cr.openjdk.java.net/~igerasim/8020669/5/webrev/
<http://cr.openjdk.java.net/%7Eigerasim/8020669/5/webrev/>
Thanks for the updated the webrev, the expansion of the capacity is
much nicer now. As regards whether to double or increase by
BUFFER_SIZE then it's probably a coin toss. One could come up with
cases where someone is using this method on a file that is extended by
another entity. It would depend on the extend rate as to which
approach would be more efficient (clearly such cases are going to be
problematic as file locking should be used to coordinate the access).
As regards the comment on "Reads" vs "Read", that was more just I've
wasn't sure if you had intended to include this or not.
So I'm happy to sponsor this for you (assuming we are done).
-Alan.
