Looks good.

Masayoshi

On 8/9/2013 4:19 AM, Xueming Shen wrote:
Thanks Masayoshi, good catch, yes, those two aliases should be included.
Webrev has been updated according.

webrev:
http://cr.openjdk.java.net/~sherman/6614237/webrev/

-Sherman

On 08/04/2013 10:17 PM, Masayoshi Okutsu wrote:
Hi Sherman,

IANA seems to define the following aliases for IBM290.

cp290
EBCDIC-JP-kana
csIBM290

The alias table should include EBCDIC-JP-kana and csIBM290 as well?

Otherwise, the changes look good to me.

Thanks,
Masayoshi

On 8/3/2013 5:53 AM, Xueming Shen wrote:
Masayoshi,

Would you please help review this change? The changeset also adds the requested Cp300.

webrev:
http://cr.openjdk.java.net/~sherman/6614237/webrev/

original mapptables:
http://cr.openjdk.java.net/~sherman/6614237/290/
http://cr.openjdk.java.net/~sherman/6614237/300/

regression tests:
http://cr.openjdk.java.net/~sherman/6614237/closed

Thanks!
-Sherman




Reply via email to