On 09/08/2013 11:36, Lance Andersen - Oracle wrote:
Hi Joe,
The changes look fine
+1 Looks ok to me. Pitty we have to maintain this kind of usage!
-Chris.
Best
Lance
On Aug 9, 2013, at 1:57 AM, huizhe wang wrote:
Hi,
The root cause of this issue is that SPECJVM2008 uses a 3rd party parser XOM 1.1 to convert the output to its
canonical form. The XOM parser directly references to the JDK parser implementation "SAXParser"
with a different configuration than the default JDK parser, in this case, the DTD-only parser configuration
"DTDConfiguration". In JAXP 1.5, we added XMLSecurityPropertyManager that is instantiated in the
default configuration "XML11Configuration". Since XMLSecurityPropertyManager is not supported by
DTDConfiguration, XOM no longer works.
This patch is to add the XMLSecurityPropertyManager to DTDConfiguration so that
XOM will continue to work properly with jdk8/7u40. I don't know if there's any
library out there that calls into NonValidatingConfiguration directly. Since
it's in a similar situation as DTDConfiguration, I added
XMLSecurityPropertyManager support as well.
webrec: http://cr.openjdk.java.net/~joehw/jdk8/8022548/webrev/
test:
I created a new test that runs with xom1.1.jar on the classpath, and
passed.
all unit tests/SQE regression tests passed
Thanks,
Joe
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected]
