On 08/07/2013 06:42 PM, Aleksey Shipilev wrote:
Hi Peter,

On 08/07/2013 08:18 PM, Peter Levart wrote:
http://cr.openjdk.java.net/~plevart/jdk8-tl/AnnotationData/webrev.01/
Yeah, looks familiar. The install loop is very complicated though, can
we simplify it? It seems profitable to move the retry loop up into
annotationData(): you then don't have to pass the $annotationData, you
can merge the exit paths for $classRedefinedCount, etc.

Hi Aleksey,

Right, the retry-loop can be simplified. There are still two methods, but the 2nd is only a factory method now:

http://cr.openjdk.java.net/~plevart/jdk8-tl/AnnotationData/webrev.02/

10 LOC saved.


Regards, Peter

-Aleksey.




Reply via email to