On 9/2/2013 6:29 AM, Daniel Fuchs wrote:
Hi,
Please find below a fix for:
8016127: NLS: logging.properties translatability recommendation
<http://cr.openjdk.java.net/~dfuchs/webrev_8016127/webrev.03/>
This change looks fine.
As for the cached localized name and the tranisent localizedLevelName
field which was a regression introduced in 7u13, it'd be worth filing a
separate bug to track it. Having one changeset with two bug ids is fine.
thanks
Mandy
This fix corrects localized Level names in JDK 8.
It updates the logging.properties resource bundles to follow
internationalization guidelines: all caps words are usually considered
as constant names that must not be translated - and the base
resource bundle logging.properties - will no longer contain
capitalized names.
The changeset contains a test that will verify that
the logging.properties bundles are correct - which should
hopefully catch translation issues early int the process and avoid
last minutes fire-drills like we had in the past.
To make the test pass, I had to replace the untranslated bundles
from JDK 8 by their translated version from JDK 7u-dev.
The fix also makes sure that the Level names will still be printed
in all caps, even if their translation isn't.
As per Mandy's request I also took this opportunity to fix the
localized name caching mechanism which didn't take into account
possible changes of the default locale returned by
Locale.getDefault().
best regards,
-- daniel
