I believe it produced extraneous output -- it was not clear to me that it was either necessary or useful to fully describe all the converted exceptions that lead to the defined exception being thrown. The commented line should have just been removed (I think).
On 2013-09-12, at 1:24 PM, Christian Thalinger <christian.thalin...@oracle.com> wrote: > + // err.initCause(ex); > > Why is this commented? > > -- Chris > > On Sep 6, 2013, at 4:59 PM, David Chase <david.r.ch...@oracle.com> wrote: > >> new, improved webrev: http://cr.openjdk.java.net/~drchase/8022701/webrev.02/ >> Same small changes to the sources, plus a test. >> >> bug: wrong exception was thrown in call of methodhandle to private method >> >> fix: detect special case of IllegalAccessException, convert to >> IllegalAccessError >> >> testing: >> verified that the test would pass with modified library >> verified that the test would fail with old library >> verified that the test would fail if the class substitution (for some >> reason) did not occur >> jtreg of jdk/test/java/lang/invoke -- note that the new exception thrown is >> a subtype of the old one, so this is unlikely to create a new surprise >> >> >> _______________________________________________ >> mlvm-dev mailing list >> mlvm-...@openjdk.java.net >> http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev >
