The changes look fine to me too.
With such a trivial change to hotspot it may be possible to push this
through TL?
Trivially, and separate to this change, I can see further cleanup
opportunities [1], as well as some tests that ref alt-rt.jar [2] [3].
Not that I really care (but I know others do), will the old build still
work after these changes?
-Chris.
[1]
http://hg.openjdk.java.net/jdk8/jdk8/langtools/file/1b7f5a27c4ba/src/share/classes/com/sun/tools/jdeps/PlatformClassPath.java
(L99)
[2]
http://hg.openjdk.java.net/jdk8/jdk8/langtools/file/1b7f5a27c4ba/test/tools/javac/processing/model/testgetallmembers/Main.java
(L136)
[3]
http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/b67c8099ba28/test/sun/reflect/CallerSensitive/CallerSensitiveFinder.java
(L228)
On 09/17/2013 04:24 AM, Mike Duigou wrote:
On Sep 16 2013, at 19:37 , David Holmes wrote:
Reviewed both hotspot and jdk changes.
Thumbs up and good riddance! :)
How do you propose to handle the coordination of the push?
The hotspot and jdk changes can go in any order. I plan to push them sequential
after cross platform test build along with the closed source portion. The
closed portion has to happen after the open jdk repo makefile changes.
Mike
Thanks,
David
On 17/09/2013 10:16 AM, Mike Duigou wrote:
Hello all;
This is a cross-repo patch which disables building and enabling of the
alt-rt.jar file. The alt-rt.jar file has been used with the -XX:+AggressiveOpts
option (which will be remaining for other optimizations). This jar file
formerly contained (closed-source) versions of several JDK classes which were
optimized for very specific workloads. The implementations weren't generally
applicable and in many cases induced performance drops. In particular since we
will not be providing optimized implementations of the Java 8 streams API for
the alternate versions of these classes the performance relative to the
standard implementations would be poor.
Over time we've (largely Alan Bateman) been trying to eliminate this difficult
to support feature. With this changeset the alt-rt.jar feature is retired.
http://cr.openjdk.java.net/~mduigou/JDK-8024826/0/webrev/
Ideally I would like a reviewer for both the HotSpot and JDK repos (could be
the same person).
Mike
