Hi Kumar,

Here are my comments:

cmdtoarg.c

- Line 151: 'p' is not used anywhere. Remaining debugging code?
- Line 155: Although this seems to do no harm, but it is not necessary.

I18NArgTest.java

- Currently it is testing only "Katakana SO" which is a single character. Maybe some more cases need to be tested?

Naoto

On 9/20/13 2:59 PM, Kumar Srinivasan wrote:
Hi Naoto, Sherman, Akhil,

Can you please review this:
http://cr.openjdk.java.net/~ksrini/8016110/webrev.0

Bug:
http://bugs.sun.com/view_bug.do?bug_id=8016110

The code was provided by IBM, I wrote up the test.

Thanks
Kumar



Reply via email to