Thanks all, committing after successful tests.
On 10/01/13 14:33, Joe Darcy wrote: > Looks fine; cheers, > > -Joe > > On 10/1/2013 11:18 AM, Eric McCorkle wrote: >> I forgot to hg add the test. I've addressed your and others' comments, >> and refreshed the webrev. Please review. >> >> On 10/01/13 04:06, Joel Borggren-Franck wrote: >>> Hi Eric, >>> >>> Thanks for fixing this. >>> >>> On 2013-10-01, Eric McCorkle wrote: >>>> Hello, please review this simple patch which fixes a problem in the >>>> type >>>> annotations handling API. This manifests as a problem with both >>>> j.l.r.Parameter.getAnnotatedType().getType() as well as >>>> j.l.r.Executable.getAnnotatedParameterTypes().getType(). >>>> >>>> The webrev is here: >>>> http://cr.openjdk.java.net/~emc/8021398/ >>>> >>>> The bug report is here: >>>> https://bugs.openjdk.java.net/browse/JDK-8021398 >>>> >>> Fix looks mostly fine, but please use the shared array on line 47 >>> instead of allocating a new one. >>> >>> Also you lack a test, adopt the test from the bug and add it to >>> jdk/test/java/lang/annotations/typeAnnotations/ >>> >>> cheers >>> /Joel >>> >
