Hi Mandy, On 10/3/13 9:29 PM, Mandy Chung wrote:
test/java/util/ResourceBundle/getBaseBundleName/TestGetBaseBundleName.java 109 return new Vector<String>(java.util.Arrays.asList( 110 new String[] {"dummy"})).elements(); Could you use Collections.enumeration?
Excellent! Yes I will.
test/java/util/logging/Logger/logrb/TestLogrbResourceBundle.java 194 if (foobaz.getResourceBundleName() != null) { 195 throw new RuntimeException("Unexpected bundle: " 196 + foobar.getResourceBundle()); 197 } I guess you meant to print foobar.getResourceBundleName() in line 196.
Oops - yes - thanks for catching that.
The test cases are good. It'd be good to add some comments to describe what each case verifies when appropriate. You can make these changes before you push. No need for a new webrev.
OK - thanks -- daniel
thanks Mandy