Hi Karen, I agree with the others, the code looks good though I like Paul's suggestion.
Silly question perhaps, do you know if we have good test coverage on actually reflectively invoking a Method more than 15 times? cheers /Joel On 2013-10-09, Karen Kinnear wrote: > > Please review: > > webrev: http://cr.openjdk.java.net/~acorn/8026213/webrev/ > bug: https://bugs.openjdk.java.net/browse/JDK-8026213 > > Summary: > Reflection generates code dynamically to speed up reflection processing after > startup. The first > 15 runs of a reflection call use the vm code path, after that we use the > generated code path, which > needs to use invokespecial on private methods in interfaces. > > Tested: > Test attached to the bug > > Also - all the 8011311 private method testing was run with this in the build: > Robert Field's TypeTest > 8025475 test > defmeth privatemethodstest with reflection > John Rose's intfbug > jtreg: java.util, java.lang > jck vm, lang > > thanks, > Karen > >
