Thanks for review Stuart. I meant to give the public link. Here it is
for records :
http://cr.openjdk.java.net/~coffeys/webrev.5036554.jdk8/webrev/
<http://cr.openjdk.java.net/%7Ecoffeys/webrev.5036554.jdk8/webrev/>
regards,
Sean.
On 23/10/2013 06:00, Stuart Marks wrote:
Seems like a sensible fix.
(Note: your webrev appears to be on an internal server, not visible to
the public, but nothing there is confidential to my eye.)
It's unfortunate that the test involves creating another shell script
test, but the alternative is probably a lot of work to develop a corba
test library that knows how to run idlj and compile classes against
the generated output. Oh well.
s'marks
On 10/22/13 12:44 PM, Seán Coffey wrote:
This corba fix was fixed many moons ago in JDK5. Bad records meant it
didn't get
forward ported to JDK6 and later families. We need to fix that now.
I'm looking
to push this to jdk8-tl and backport to jdk7u-dev shortly afterwards.
bug ID : https://bugs.openjdk.java.net/browse/JDK-5036554
webrev :
http://t4.ie.oracle.com/home/sean/jdk8_tl.2/webrev.5036554.jdk8/webrev/
regards,
Sean.
