On 11/3/13 10:52 PM, Peter Levart wrote:
On 11/04/2013 05:45 AM, Mandy Chung wrote:
On 11/3/2013 5:32 PM, David Holmes wrote:
Hi Mandy,
On 2/11/2013 7:11 AM, Mandy Chung wrote:
On 11/1/13 1:37 PM, mark.reinh...@oracle.com wrote:
2013/11/1 4:15 -0700, mandy.ch...@oracle.com:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8027351/webrev.00/
Looks good.
Just one question: In Finalizer.java, at line 97 you look up the
JavaLangAccess object every single time. Is it worth caching that
earlier, maybe when the finalize thread starts, since it will never
change?
I was expecting that would get optimized during runtime and it's a
simple getter method. It's a good suggestion to cache it at the
finalize
thread start time and here is the revised webrev:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8027351/webrev.01/
I'm missing something basic - how did you get this to compile:
public void invokeFinalize(Object o) throws Throwable {
o.finalize();
}
given finalize is protected ??
protected members can be accessed by the same package and
subclasses. This is the implementation of JavaLangAccess in
java.lang.System that is in the same package as java.lang.Object.
Also VM.awaitBooted seems inherently risky as a general method as
you would have to make sure that it is never called by the main VM
initialization thread. Perhaps handle this in
sun.misc.SharedSecrets.getJavaLangAccess so it is less 'general'?
That sounds a good idea. Let me think about it and get back to this.
That said I think Peter may be right that there could be races with
agents triggerring explicit finalization requests early in the VM
initialization process - which means any blocking operation
dependent on other parts of the initialization sequence could be
problematic.
Hmm... agents calling System.runFinalization during startup - like
Alan described, the agent is playing fire.
Hi Mandy,
Isn't System.runFinalization() just a "hint"? Like System.gc() for
example...
* <p>
* Calling this method suggests that the Java Virtual Machine expend
* effort toward running the <code>finalize</code> methods of objects
* that have been found to be discarded but whose
<code>finalize</code>
* methods have not yet been run. When control returns from the
* method call, the Java Virtual Machine has made a *best effort* to
* complete all outstanding finalizations.
* <p>
Couldn't the request just be ignored when called before VM.isBooted()
? The finalizers will be executed nevertheless asynchronously later by
the finalizer thread...
That's also what I thought about last night after I sent my reply.
Mandy
