On 29/11/2013 20:06, Ivan Gerasimov wrote:
I modified the patch in the way you suggest.
http://cr.openjdk.java.net/~igerasim/6968459/1/webrev/
The timeOut variable now holds the remaining time.
If the system time had changed back, we start counting from the
beginning.
If it had changed forward, we have no way to catch it and the timeout
gets elapsed earlier.
This looks okay to me although one thing that isn't clear to me is
whether removeRequest needs to be called on no-timeout or
InterruptedNamingException cases (Vinnie or Xuelei might have the
background in the code to say for sure).
I see the patch doesn't come with a test. Is there any test
infrastructure for testing LDAP without require a complete server?
I didn't find anything like that, that's why I set 'noreg-hard' label.
Okay although I think we should consider (via a different bug of course)
putting a simple LDAP server into the test tree so that tests for the
LDAP provider can be added in the future.
-Alan
