On 12/04/2013 06:50 PM, Brian Burkhalter wrote:
On Dec 4, 2013, at 6:20 PM, Alan Eliasen wrote:
Hmmm... it looks like that patch is correct and necessary if
getLower() is receiving negative numbers. I'm not quite sure what
happened there. My vague recollection was that at one point the
arguments to Karatsuba multiply were conditioned to always be positive
in the multiply() dispatching function, but that's apparently not the
case in the current code.
Thanks for the comments. There is no guarantee that the factors will not be
negative. The main thing is that it got caught before the release of 8.
Brian,
As a double-check, can you run the now failing regression test against
the earlier versions of java.math.* between when Karatsuba and friends
went in and the current version of the code?
Thanks,
-Joe
