On 12/11/2013 3:21 PM, Kumar Srinivasan wrote:
Hello,
Please review a fix for Windows launcher where it consumes application
args
-d32 and -d64, the fix is to stop the scan when it hits the
Application sentinel
ie. class-name or jar-name.
http://cr.openjdk.java.net/~ksrini/8029388/webrev.0/
Nit: can we start checking from argv[1] and skip argv[0]? line 194 no
need to check i > 0 then.
Nit: line 95 - an extra space before "dmodel". A general question -
doExec handles the case when the cmd terminates with an exception. I
was wondering if the generated Args class should just throw an exception
if it doesn't match the expected value (i.e. have Args class to do the
verification). I pondered a little bit when reading the verifyOption
method before I read the createOptionsJar method.
Otherwise, looks good.
Mandy
