On 27/12/2013 00:34, Brian Burkhalter wrote:
Sounds reasonable. There was previously mention of this getting in before b01
so I wanted to resurface it now.
Brian
I see Joe's mail asking me to comment but I don't think I have much to
add except that when running in agentvm mode + concurrency then it
"normal" to limit the heap of the agent VMs to avoid over committing
memory. For example, in jdk/test/Makefile then you'll see that the tests
are run with -vmoption:-Xmx512m.
One idea would be add an @run so that they run in othervm mode. That way
there wouldn't be any question about whether the OOME would cause side
effects that would impact tests that run subsequently in the same
(agent) VM. Another idea is to just check the heap size in the test so
that it skips when the heap size is too small (this approach might be a
faster than attempting to test and recovering from the OOME).
BTW: Just on the "@ test" then the normal way to exclude tests is to add
the @ignore tag or else add the test to the exclude list
(ProblemList.txt). Just mentioning it because someone might spot the
space and wonder if it is intentional or not.
-Alan.
