One other comment, instead of changing the return type of the
just return and the caller should check for exceptions and return.
See jni.h: CHECK_EXCEPTION(env)
On 1/10/2014 11:40 AM, roger riggs wrote:
Just pushed are macros in jni_util.h to do the same function as your
Please update to use the common macros instead of introducing new ones.
Style wise, I would avoid mixing binary operators (!) with pointers.
it is clearer to compare with NULL. (The CHECK_NULL macro will do the
check and return).
(Not a Reviewer)
On 1/10/2014 1:31 AM, Dan Xu wrote:
Please review the fix for JNI pending exception issues reported in