On 17/01/2014 13:45, Volker Simonis wrote:
:
Yes, you're right - it was because of a "VirtualBox Host-Only Network"
network device which seems to fool the test. After I disabled it, all
tests passed successfully!
And what about the change itself :)
The change itself looks mostly okay.
For naming then I think I would have a slight preference for something
like pollinValue to getNatvePollin so that it somewhat consistent with
the other places where we do this (like in epoll code with eventSize,
eventsOffset, ...). Naming is subjective of course so this isn't a big
issue.
I suspect you can drop POLLREMOVE, that is only used in the /dev/poll
Selector and it has its own definition (and shouldn't be compiled on
anything other than Solaris anyway).
A minor comment on DatagramChannelImpl, SourceChannelImpl and a few more
where the replacing PollArrayWrapper.POLL* with Net.POLL* means it is no
longer necessary to split lines (just might be neater to bring these
cases back on the one line again).
I suspect we will be able to drop the changes to the Windows nio_util.h
soon as these older versions of Windows are not long for this world. I
assume that by taking on newer VC++ that it won't even be possible to
build or run either.
-Alan.
