On Jan 17, 2014, at 5:09 PM, Brian Goetz <[email protected]> wrote:
> Webrev at: > http://cr.openjdk.java.net/~briangoetz/JDK-8031373/webrev/ > > If someone with ASM fu (Remi?) could sanity check the JLI changes, that would > be appreciated. > Stream code looks good. I notice some other things in StreamSpliterators that could potentially be cleaned up too: - Might be a redundant cast: 312 ph.wrapAndCopyInto((Sink<P_OUT>) consumer::accept, spliterator); - Error in JavaDoc: 1324 * The {@coe tryAdvance} method always returns true. -- IIUC the ASM related updates are due to the deprecated method. The new method allows for invokespecial/static on methods of interfaces and placing the correct data in the constant pool. In which case i would expect all the updates to have a false as the last parameter, which is so. Still, as say Remi's eyes would be useful on this one. Paul.
