On 02/10/2014 05:36 PM, Alan Bateman wrote:
On 10/02/2014 07:00, michael cui wrote:
:
Please review the newest version at :
http://cr.openjdk.java.net/~tyan/michael/JDK-8028711/webrev.03/
This looks good to me.
There are a couple of places where javac wasn't updated. A few that I
noticed are:
test/com/sun/corba/5036554/TestCorbaBug.sh
test/sun/tools/jconsole/ResourceCheckTest.sh
test/sun/tools/native2ascii/resources/ImmutableResourceTest.sh
The original code change did adding ${TESTTOOLVMOPTS} to javac, but I
dropped it from new proposal.
My understanding is that vmoption for javac would not change the
compiler's behaviour. I could be wrong.
Do you think we really need to pass such vm options to javac? And if it
is needed, than how about other java tools such as jar, rmiregistry, ...
etc.
A minor comment on test/java/net/URLPermission/nstest/lookup.sh is
that the resulting line length is 182 characters and this will likely
be annoying for future side-by-side views. So I think I'd split this
while you are there.
I will split it after finalize the changes that we want to make.
-Alan.
-Michael Cui
