Hi Mandy, thanks for the review.
I'll look into the possibility of removing Assert.sh altogether and post a new webrev soon. Regards, Volker On Tue, Mar 11, 2014 at 2:59 AM, Mandy Chung <mandy.ch...@oracle.com> wrote: > > On 3/10/2014 11:55 AM, Mandy Chung wrote: >> >> Hi Volker, >> >> On 3/10/14 11:16 AM, Volker Simonis wrote: >>> >>> Hi, >>> >>> could you please review the following trivial change which adds AIX to >>> the list of known OSs in test/java/lang/ClassLoader/Assert.sh: >>> >>> https://bugs.openjdk.java.net/browse/JDK-8037013 >>> http://cr.openjdk.java.net/~simonis/webrevs/8037013/ >>> >> >> The link to your webrev is not accessible and could possibly due to the >> server issue. I guess your fix is to add AIX in the Assert.sh test. Can >> you paste the diff in mail? I can review it. >> > > I am able to access the webrev now - looks good. > > >> I raised in the code review of 7152892 [1] that I believe this test >> doesn't need to be a shell test. I don't know if Rob has started looking >> into it (he missed my review comment when he pushed the fix). I wonder if >> you would like to take the opportunity to investigate if Assert.sh can be >> removed? >> > > It'd be even better if we could get rid of Assert.sh. > > thanks > Mandy > >> Mandy >> [1] >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-February/024995.html > >
