On 3/12/14 7:34 PM, Mandy Chung wrote:

On 3/12/2014 11:27 AM, Daniel Fuchs wrote:
Hi,

Please find below a trivial fix for [1]:

8036916: Deprecation warnings in LogManager
[1] https://bugs.openjdk.java.net/browse/JDK-8036916

webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8036916/webrev.00/

Oops.. I didn't catch the typo in the @SuppressWarnings previously.

Looks okay.  Could isRootOrGlobal do return logger == getGlobalLogger()
|| .... to avoid another @SuppressWarning?  Really minor.

Hi Mandy,

Oh - of course - we don't need the new method actually. I was not
thinking right:

http://cr.openjdk.java.net/~dfuchs/webrev_8036916/webrev.01/

best regards,

-- daniel


Mandy


Reply via email to