Looks good to me. The version with JNI_TRUE/JNI_FALSE is more correct, but I’m fine with either one.
(note: this review request should have been sent to serviceability-dev). Thanks, /Staffan On 21 mar 2014, at 20:41, Brian Burkhalter <brian.burkhal...@oracle.com> wrote: > Please review at your convenience: > > Issue: https://bugs.openjdk.java.net/browse/JDK-8038163 > Patch: http://cr.openjdk.java.net/~bpb/8038163/ > > My only question would be whether the changed line 291 should instead be this: > > return (major > 1 || (major == 1 && minor >= 2)) ? JNI_TRUE : JNI_FALSE; > > Thanks, > > Brian
