I’ve looked at the changes in StreamPumper and ProcessTools: they look good.

Since the rest of the code is a straight backport, I didn’t look at it.

Reviewed.

Thanks,
/Staffan

On 6 mar 2014, at 16:34, Vladimir Kempik <vladimir.kem...@oracle.com> wrote:

> Please review this change to update jdk part of testlibrary in jdk7.
> 
> It updates testlibrary with new apis from jdk8's testlibrary.
> 
> When porting jdk8's testlibrary to jdk7, I had to make few changes:
> 
> 1) rewrite one lambda usage in StreamPumper.java to non-lambda version.
> 
> 2) get rid of predicate functionality in ProcessTools.java: startProcess as 
> it wasn't used anyway and unsupported in jdk7.
> 
> Every test in open part of jdk that uses testlibrary still works after update 
> (in fact there are 3 of them).
> 
> Webrev:
> http://cr.openjdk.java.net/~vkempik/8036786/webrev.00/
> 
> Thanks, Vladimir.

Reply via email to