I have to say that the expected NPE is quite "hidden" in the current code. I am actually surprised someone was able to catch that. The use of Objects.requreNonNull() is way more clear and I prefer that approach for the sake of clarity.
On Mon, Apr 28, 2014 at 8:28 AM, Otávio Gonçalves de Santana < [email protected]> wrote: > Done. > Link: > > https://dl.dropboxusercontent.com/u/16109193/open_jdk/string_to_string_uncessary.zip > > > On Mon, Apr 28, 2014 at 4:34 AM, Paul Sandoz <[email protected]> > wrote: > > > Hi Otávio, > > > > Is there anyway you can experiment with publishing a webrev to dropbox or > > github, preferably so that it is browsable, otherwise the zip? > > > > Unfortunately the patches are hard to review, especially in response to > > reviews where code is updated. > > > > I realize until you have an openjdk account you are somewhat in "no-mans" > > land, but i strongly suspect using one of the above mentioned services is > > fairly easy to use, and therefore will make it easier to accept such > > patches. > > > > Paul. > > > > On Apr 27, 2014, at 3:15 PM, Otávio Gonçalves de Santana < > > [email protected]> wrote: > > > > > There is an issue that was opened to remove redundant calls of > toString() > > > on String objects. [1] > > > I went deep on all JVM sources and I found all, 32 changes. > > > > > > > -- > Atenciosamente. > > Otávio Gonçalves de Santana > > blog: http://otaviosantana.blogspot.com.br/ > twitter: http://twitter.com/otaviojava > site: http://www.otaviojava.com.br > (11) 98255-3513 > -- Cheers, Paul
