Pushed. You may now resume normal integration activities.
On 05/09/14 15:12, Staffan Larsen wrote: > Looks good. > > Many apologies. > > /Staffan > > > On 9 maj 2014, at 21:08, Eric McCorkle <eric.mccor...@oracle.com> wrote: > >> The following patch will fix it: >> >> diff -r 7426549b1e3b >> src/solaris/native/sun/tools/attach/SolarisVirtualMachine.c >> --- a/src/solaris/native/sun/tools/attach/SolarisVirtualMachine.c >> +++ b/src/solaris/native/sun/tools/attach/SolarisVirtualMachine.c >> @@ -1,4 +1,4 @@ >> -''/* >> +/* >> * Copyright (c) 2005, 2014, Oracle and/or its affiliates. All rights >> reserved. >> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> * >> >> On 05/09/14 15:01, Eric McCorkle wrote: >>> The problem is a stray '' as the first two characters in the file. >>> >>> I have posted a patch that removes it to serviceability-dev. >>> >>> All we need is someone with Reviewer/committer rights to step in and >>> apply it. >>> >>> On 05/09/14 14:48, Alejandro E Murillo wrote: >>>> >>>> Definitively a P1. >>>> This is also blocking this week hotspot snapshot: >>>> http://prt-web.us.oracle.com//archive/2014/05/2014-05-09-174238.amurillo.jdk9-hs-2014-05-09-jdk9-dev-control/logs/solaris_sparcv9_5.10-fastdebug.log.FAILED.log >>>> >>>> please fix ASAP >>>> >>>> Thanks >>>> Alejandro >>>> >>>> On 5/9/2014 12:16 PM, Eric McCorkle wrote: >>>>> Bug created: https://bugs.openjdk.java.net/browse/JDK-8042859 >>>>> >>>>> This patch seems to be the culprit: >>>>> >>>>> changeset: 9908:7426549b1e3b >>>>> tag: tip >>>>> user: sla >>>>> date: Fri May 09 12:06:13 2014 +0200 >>>>> summary: 8039173: Propagate errors from Diagnostic Commands as >>>>> exceptions in the attach framework >>>>> >>>>> >>>>> On 05/09/14 14:08, Eric McCorkle wrote: >>>>>> I am currently seeing build failures on solaris, coming from within the >>>>>> JDK repo: >>>>>> >>>>>> /opt/jprt/products/P1/SS12u1/SS12u1/prod/bin/cc -DTRACING >>>>>> -DMACRO_MEMSYS_OPS -DBREAKPTS -D_BIG_ENDIAN= -DSOLARIS >>>>>> -DARCH='"sparcv9"' -Dsparcv9 -DNDEBUG -DTRIMMED >>>>>> -DRELEASE='"1.9.0-internal"' >>>>>> -I/tmp/jprt/P1/173806.emccorkl/s/build/solaris-sparcv9-normal-server-release/jdk/include >>>>>> >>>>>> -I/tmp/jprt/P1/173806.emccorkl/s/build/solaris-sparcv9-normal-server-release/jdk/include/solaris >>>>>> >>>>>> -I/tmp/jprt/P1/173806.emccorkl/s/jdk/src/share/javavm/export >>>>>> -I/tmp/jprt/P1/173806.emccorkl/s/jdk/src/solaris/javavm/export >>>>>> -I/tmp/jprt/P1/173806.emccorkl/s/jdk/src/share/native/common >>>>>> -I/tmp/jprt/P1/173806.emccorkl/s/jdk/src/solaris/native/common -m64 >>>>>> -D__solaris__ -xc99=%none -xCC -errshort=tags -Xa -v -mt -W0,-noglobal >>>>>> -KPIC -xstrconst -xregs=no%appl >>>>>> -I/tmp/jprt/P1/173806.emccorkl/s/build/solaris-sparcv9-normal-server-release/jdk/gensrc_headers >>>>>> >>>>>> -errtags -errwarn=%all -g -xs -xO2 -Wc,-Qrm-s -Wc,-Qiselect-T0 >>>>>> -DTHIS_FILE='"SolarisVirtualMachine.c"' -c -xMMD -xMF >>>>>> /tmp/jprt/P1/173806.emccorkl/s/build/solaris-sparcv9-normal-server-release/jdk/objs/libattach/SolarisVirtualMachine.d.tmp >>>>>> >>>>>> -o >>>>>> /tmp/jprt/P1/173806.emccorkl/s/build/solaris-sparcv9-normal-server-release/jdk/objs/libattach/SolarisVirtualMachine.o >>>>>> >>>>>> /tmp/jprt/P1/173806.emccorkl/s/jdk/src/solaris/native/sun/tools/attach/SolarisVirtualMachine.c >>>>>> >>>>>> "/tmp/jprt/P1/173806.emccorkl/s/jdk/src/solaris/native/sun/tools/attach/SolarisVirtualMachine.c", >>>>>> >>>>>> line 1: empty character constant >>>>>> "/tmp/jprt/P1/173806.emccorkl/s/jdk/src/solaris/native/sun/tools/attach/SolarisVirtualMachine.c", >>>>>> >>>>>> line 1: syntax error before or at: '' >>>>>> gmake[2]: *** >>>>>> [/tmp/jprt/P1/173806.emccorkl/s/build/solaris-sparcv9-normal-server-release/jdk/objs/libattach/SolarisVirtualMachine.o] >>>>>> >>>>>> Error 1 >>>>>> >>>>>> This is blocking integration of patches that need to go in promptly. >>>>>> This needs to be addressed ASAP. >>>>>> >>>> >
