Hi joe, Should be a comma at the end of line 8 before the and on line 9
Looks ok otherwise Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Jun 30, 2014, at 4:07 PM, huizhe wang <huizhe.w...@oracle.com> wrote: > That makes sense. I changed @since back to 1.4 and added L2 in the > description: > > http://cr.openjdk.java.net/~joehw/jdk9/8037948/webrev/ > > Thanks, > Joe > > On 6/30/2014 12:35 PM, Henry Jen wrote: >> On 06/30/2014 12:26 PM, Lance Andersen wrote: >>> >>> On Jun 30, 2014, at 3:22 PM, huizhe wang <huizhe.w...@oracle.com> >>> wrote: >>> >>>> >>>> On 6/30/2014 12:20 PM, Lance Andersen wrote: >>>>> Looks OK Joe, noticed the @since changed as well? >>>> >>>> Thanks for review. >>>> >>>> Yes. The support for DOM L3 was since JDK 1.5. Previously this >>>> package file mentioned only DOM L2. >>> >>> OK, thank you. Just seemed strange that the overall version was >>> changed as I suspect L3 is compatible with L2. I might have just >>> indicated that L3 was added in 1.5 as the support was initially in >>> 1.4 I believe. I have no strong preference though >> >> I agree with Lance here, the package itself is included in JDK since 1.4. >> >> In case classes under this package is not properly labeled with @since tag, >> they will be considered has the same @since as package.html, then that would >> be really misleading. >> >> Cheers, >> Henry >