On 07/01/2014 05:31 PM, Stuart Marks wrote:
On 6/30/14 8:17 AM, Henry Jen wrote:
On 06/30/2014 12:18 AM, Alan Bateman wrote:
On 30/06/2014 02:30, Henry Jen wrote:
On 06/20/2014 02:28 PM, Henry Jen wrote:
Please review a trivial webrev for jdk9/corba that do the same @since
tag normalization as in jdk9/jdk.
http://cr.openjdk.java.net/~henryjen/jdk9/8047722/0/webrev/
There are bunch of @since JDK 1.0 and JDK 1.1.6 that you are
changing to
1.0 and 1.1.6. AFAIK, CORBA was added in 1.2 and I wonder if we should
fix this as part of this change.
Thanks for review. You are correct that CORBA was added in 1.2.
My understadning to those 1.0 to 1.1.6 versions are for override
methods, I
guess the author is putting down the version of the origin.
There are several cases where @since can be ambiguous without a
common guideline,
- An method was private or package access only made public, should
@since denote
the API availablity or the implementation?
- APIs from classed was extracted into a super class or interface in
a later
version, what should be the @since?
FWIW, when I did that kind of operation moving methods from
java.lang.reflect.{Method, Constructor} into the new j.l.r.Executable in
JDK 8
http://hg.openjdk.java.net/jdk9/dev/jdk/rev/d083644bc615
I defined overriding methods in the subclasses sometimes just for the
purpose of creating a location where the semantics of the text could be
{@inheritDoc}'ed with a distinct @since value.
-Joe
