Thanks Alan! Just for the record the 'final' webrev is here: http://cr.openjdk.java.net/~dfuchs/webrev_8048020/webrev.02
I will push this shortly... -- daniel On 7/4/14 8:24 PM, Alan Bateman wrote:
On 04/07/2014 19:10, Daniel Fuchs wrote:hmmm. yes - you're right. I should catch that to and break the loop in that case. So that would become: 465 } catch (NoSuchFileException x) { 466 // Race condition - retry once, and if that 467 // fails again just try the next name in 468 // the sequence. 469 continue; 470 } catch (IOException x) { // the file may not be writable for us. // try the next name in the sequence break; } Thanks for the feedback Alan! I had missed those cases.If that is the final change then I think I'm okay (no need to generate a new webrev). I do think it could be improved a bit more by dropping the isXXX checks but it's not important. -Alan
