On Jul 8, 2014, at 12:09 PM, Vladimir Ivanov <vladimir.x.iva...@oracle.com> wrote: > I'd like to revive this review thread. > > Updated version: > http://cr.openjdk.java.net/~vlivanov/8037209/webrev.04/ >
Seems ok. I don't claim to be knowledgable enough in the finer points of conversion/casting/verification but i could see anything obviously wrong with the code. > Paul, I'd like to address your case (if possible) separately. Right now, I > don't see any way to avoid null check you see with your tests. > Ok, thanks. I was naively pondering whether it would be worth while replacing the cast with an intrinsic Unsafe.typeProfile(Class c, Object o, boolean isNullInteresting), then that could be called with (c, instance, false), although dunno if that would be any easier to solve. Paul.
