Thanks for review Sherman. I'll go ahead and push current changes. Not
sure what to do with the zlib launcher reference. Most likely not needed
but we can rip that code out under a new bug ID if necessary.
regards,
Sean.
On 08/09/2014 18:34, Xueming Shen wrote:
On 09/03/2014 03:05 AM, Seán Coffey wrote:
I'd like to port the zlib v1.2.8 libraries to JDK 7u. Currently, 7u
uses zlib v1.2.3 libraries. 8u20 was recently upgraded to 1.2.8. zlib
fixes since 1.2.3 can be found at
http://cr.openjdk.java.net/~coffeys/webrev.8044725.7u/webrev/raw_files/new/src/share/native/java/util/zip/zlib-1.2.8/ChangeLog
While porting, I noticed that the Program.gmk had a bad reference in
it to zlib 1.1.3 (JDK6 version) - I've corrected that to 1.2.8 for
now but question if the extra INCLUDE directive is even needed.
bug report : https://bugs.openjdk.java.net/browse/JDK-8044725
webrev : http://cr.openjdk.java.net/~coffeys/webrev.8044725.7u/webrev/
regards,
Sean.
looks fine.
I'm not sure about the program.gmk...in the past the other two places
that need the zlib
src reference are the launcher and the splash code.
-sherman
