On 9/11/2014 12:43 AM, Alan Bateman wrote:
On 10/09/2014 23:11, huizhe wang wrote:
Thanks Martin!
Looks like the initial version of the jaxp port (from Xerces 2.7.1)
missed the patch for reasons I don't know. I created a bug based on
the very original bug report:
https://bugs.openjdk.java.net/browse/JDK-8058175
Joe - what's the test coverage like of this area in OpenJDK? I see
Martin has pushed this change but I just wonder if there is an
opportunity to add or improve tests, particularly for subtle cases
like this.
Yes, it would have been nice if we could find the test. Unfortunately
the original bug report was on old Apache Bugzilla that was retired a
long time ago. I couldn't find any more information than I posted in
JDK-8058175. It may be possible to create a new test, but since the
patch has been in Apache over 10 years, plus as Martin said, it's been
used at Google, I took the liberty to trust that the patch is fine so we
didn't have to spend more time on a quite fix like this.
I took Martin's patch to run existing SQE and Unit tests, they did all pass.
Thanks,
Joe
-Alan
