> Please review this 2nd version of the fix taking into account your feedback.
I'm not recognized here as a reviewer, but the code looked OK to me and it passed my patch test suite. > I have merged HALF_UP and HALF_DOWN cases into a single switch case. Good to know. My current patch injects a method call to shim code immediately after the HALF_UP case label. I need to account for this or else the applied patch could potentially cause HALF_DOWN to behave the same as HALF_UP! Thankfully, this is easily detectable in the bytecode (not that the impact to my patch is of much concern to the core devs, but it dove-tails nicely). I'm looking forward to seeing this merged and the bug fixed/closed. For my company, the sooner this makes it into an 8u update, the better. Thanks, Olivier. -- William Price
