Thank you Coleen, Harold, Alan and Sherman
for your reviews.
Fred
On 07/10/2014 15:06, Alan Bateman wrote:
On 06/10/2014 07:32, Frederic Parain wrote:
Thank you very much for catching the JVM_O_DELETE issue.
I moved the O_DELETE support into the ZipFile.c file
(code was the same for all non-Windows platforms) and
cleaned up the original code in HotSpot.
The new webrevs:
http://cr.openjdk.java.net/~fparain/8057777/jdk_v03/
http://cr.openjdk.java.net/~fparain/8057777/hotspot_v03/
Good spot by Sherman on the OPEN_DELETE issue, it makes me wonder what
the test coverage is on this.
The updated webrev addresses the points that I brought up and looks good
(nice to see many of these functions going away).
-Alan
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
