On 13/10/2014 14:44, Amy Lu wrote:
This looks okay to me. An alternative for createZipWithLeadingGarbage is to just use Files.copy(normalZip.toPath(), leadingGarbageZip.toPath()).Please review the test fix.Test tools/jar/LeadingGarbage.java fails on Windows, wrong line separator used. Also fixed resource unclosed issue.bug: https://bugs.openjdk.java.net/browse/JDK-8058856 webrev: http://cr.openjdk.java.net/~weijun/8058856/webrev.00/
-Alan.