I realize you are just adding new bad class files to an existing test, so you're just copying the idiom in the test, but it would be 1000 times more helpful if the comments included a javap or similar listing or even a description of what (bad) class this byte[] array purports to be. Otherwise, how can anyone review that the test does what it claims, other than by hand-disassembling this byte array?

On 10/30/2014 7:41 PM, Eric McCorkle wrote:
Hello,

Please review this patch which adds tests to the JDK test suite for two
reflection bugs that require hotspot changes (JDK-8058322 and JDK-8058313)

The webrev is here:
http://cr.openjdk.java.net/~emc/8062556/

Reply via email to