Hi Tristan,
Looks good overall. Once again, it's great to see that you've made the
tests a lot cleaner, getting rid of the old report system and etc.
The only issue I see is with movies.xml. If I use patch to apply your
patch to my workspace, I get no movies.xml that in turn causes
AuctionController to fail. It's probably related how your webrev was
generated (note the error: Unexpected Error occurred reading `diff -e
/dev/null new/test/javax/xml/jaxp/functional/test/content/movies.xml`:
$?=0, err= 1 ). hg diff works fine generally, but not for changes in
binary files. Use the git option, "-git", can fix the problem. You may
see the following in your configuration:
[diff]
git = true
Thanks,
Joe
On 10/31/2014 12:16 PM, Tristan Yan wrote:
Hi Joe, Alan and all others
Would you please help reviewing these tests? The intent is moving some
JAXP tests from closed to open. The associated bug number is
https://bugs.openjdk.java.net/browse/JDK-8047962.
These tests have been ran with and without the Security Manager. All
the tests pass under both scenarios.
http://cr.openjdk.java.net/~tyan/JDK-8047962/webrev.01/
<http://cr.openjdk.java.net/%7Etyan/JDK-8047962/webrev.01/>
Thank you.
Tristan
