On 11/6/2014 8:57 PM, david.b...@oracle.com wrote: > Hi Joe, > > Thank you for the review! > >> Are you checking in the test (the one attached to the bug report)? > I was not planning on it as I do not believe we should be adding test cases > to JAXP that only test completely internal implementation classes (i.e. white > box testing) for code paths that aren't even used by JAXP itself. We would > just be making the test suite more brittle with almost zero additional > coverage of code actually used by JAXP.
Ok. It's true that it doesn't affect JAXP. -Joe > > Cheers, > -Buck > > 2014/11/07 13:30、huizhe wang <huizhe.w...@oracle.com> のメッセージ: > >> Looks good. >> >> Are you checking in the test (the one attached to the bug report)? >> >> Cheers, >> Joe >> >>> On 11/6/2014 7:08 PM, david buck wrote: >>> Hi! >>> >>> May I please have a review of this fix: >>> >>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8062608 >>> WEBREV: http://cr.openjdk.java.net/~dbuck/8062608/webrev.00/ >>> >>> Cheers, >>> -Buck
