On 11/15/2014 07:07 PM, Richard Warburton wrote:
Hi all,
[...]
A good observation. I've added variants which take a String for the charset name as well the charset variants. Having said that - wouldn't it also be a good idea to replicate the caching on the charset versions as well as the charset name? I don't see any obvious reason why this isn't possible but perhaps there's something I'm missing here. Probably cleaner as a separate patch either way. regards,
I think it will create a security hazard, if a rogue charset declare itself as UTF-8 and create a malicious charset decoder, you don't want this decoder to be shared and reused.
Rémi
Richard Warburton http://insightfullogic.com @RichardWarburto <http://twitter.com/richardwarburto>