Thanks Naoto! Yeah, I noticed that too, but I'm not comfortable enough with this code to suggest a really good naming scheme. There are 3 levels of pluralization here - Attribute Attributes Attributeses [sic]!?
On Wed, Nov 19, 2014 at 3:41 PM, Naoto Sato <[email protected]> wrote: > Hi Martin, > > The fix looks good to me. Although it is not inherently related to your fix, > there are two separate declarations of "newRunAttributes" and > "newRunAttributeValues" in ensureRunBreak() method and their usages are > different! It would be desirable to correct it. > > Naoto > > > On 11/19/14, 3:00 PM, Martin Buchholz wrote: >> >> Hey Naoto and Masayoshi, >> >> I haven't sent you a friendly code review in a while. >> >> >> http://cr.openjdk.java.net/~martin/webrevs/openjdk9/AttributedString-optimization/ >> https://bugs.openjdk.java.net/browse/JDK-8065159 >> >> (AttributedString could also independently see some testing and code >> hygiene love) >> >
