On 11/24/2014 9:12 AM, Daniel Fuchs wrote:
On 24/11/14 18:04, huizhe wang wrote:
Hi Daniel,
Would you want to add 8065748 to the @bug tag? Otherwise, the test
looks good to me.
Hi Joe,
I don't think adding 8065748 would be a good idea - since the test
doesn't test 8065748 (8065748 is about adding the test :-)).
Or am I mistaken on the meaning of @bug ?
These tags (bug, summary, author and etc.) are informational tags. For
me, I use them to locate tests or corresponding bug reports. In this
case, since there's a reference to 8065138, it's okay if you don't want
to add it.
Best,
Joe
best regards,
-- daniel
Best,
Joe
On 11/24/2014 3:30 AM, Daniel Fuchs wrote:
Hi,
Please find below a small webrev that adds a trivial sanity
test to CheckEncodingPropertiesFile.java
http://cr.openjdk.java.net/~dfuchs/webrev_8065748/webrev.00
This is as a followup of Joel's fix for
https://bugs.openjdk.java.net/browse/JDK-8065138
best regards,
-- daniel
