Hi Mandy, Thanks for the review!
The new webrev is here: http://cr.openjdk.java.net/~dfuchs/webrev_8065552/webrev.01/ The compiler doesn't want the diamond operator at line 86. It says that it cannot infer the type argument. So I left it unchanged. The rest of your comments are in. best regards, -- daniel On 01/12/14 19:50, Mandy Chung wrote:
On 12/1/14 8:29 AM, Daniel Fuchs wrote:8065552: setAccessible(true) on fields of Class may throw a SecurityException webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8065552/webrev.00/Thanks for taking this on. Looks okay in general. The comment on Class.classLoader field - may simply say "this field is filtered from reflection access, i.e. getDeclaredField will throw NoSuchFieldException". ClassDeclaredFieldsTest.java copyright year should be 2014. @summary - this test also verifies that Class.classLoader final private field is hidden from reflection access. line 86: nit: can just call "new ThreadLocal<>" Mandy
