Alan,
Highlights:
* Fixed the indenting in java.c around JLI_ReportErrorMessage(SPC_ERROR2)
* Fixed parse_manifest.c, removed the redundant check, also added some
braces to that if/else/elseif block for consistency sake.
* Updated CopyRights as well.
The changes to the last webrev are here:
http://cr.openjdk.java.net/~ksrini/8058407/webrev.01/webrev.delta/index.html
The full webrev is here:
http://cr.openjdk.java.net/~ksrini/8058407/webrev.01/index.html
Thanks
Kumar
On 05/12/2014 15:22, Kumar Srinivasan wrote:
Hello,
Please review the fix for JDK-8058407, contributed by Neil Toda,
described by JEP 231 [1]
the webrev is at: http://cr.openjdk.java.net/~ksrini/8058407/webrev.00/
Please note: The above webrev is identical to the original posted by
Neal at
http://cr.openjdk.java.net/~ntoda/8058407/webrev-03/
This looks good to me although I think in parse_manifest that you can
removed completely the line that checks for JRE-Restrict-Search as it
does nothing. A minor nit is the alignment of the calls to
JLI_ReportErrorMessage(SPC_ERROR2), you might want to check those.
-Alan.
